[Bugzilla#18865] Use any(.) over sum(.) > 0#197
Open
MichaelChirico wants to merge 1 commit intor-devel:mainfrom
Open
[Bugzilla#18865] Use any(.) over sum(.) > 0#197MichaelChirico wants to merge 1 commit intor-devel:mainfrom
MichaelChirico wants to merge 1 commit intor-devel:mainfrom
Conversation
MichaelChirico
changed the title
llrs
reviewed
Mar 5, 2025
Member
llrs
left a comment
llrs
left a comment
There was a problem hiding this comment.
I like those patches!! Thanks!
Just a minor change to make it slightly faster (I thought this was the purpose of these changes, feel free to ignore for a faster review from R core)
llrs
reviewed
Mar 5, 2025
| if(maybe) | ||
| maybe <- is(f, "genericFunction") || | ||
| (length(grep("UseMethod", deparse(f))) > 0) || | ||
| any(grepl("UseMethod", deparse(f))) || |
Member
There was a problem hiding this comment.
Suggested change
| any(grepl("UseMethod", deparse(f))) || | |
| any(grepl("UseMethod", deparse(f), fixed = TRUE)) || |
Collaborator
Author
There was a problem hiding this comment.
good catch! Agree it's an improvement. I don't have an easy workflow for updating patches, so I'll just make a note of it in the issue tracker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.r-project.org/show_bug.cgi?id=18865
Double-checking I didn't do anything sloppy